(PUP-9975) Fix dpkg provider parsing of virtual packages

[treydock]

No description provided.

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[treydock]

Old:

irb(main):002:0> lines = ["install ok installed binutils 2.30-21ubuntu1~18.04.2 [binutils-gold, elf-binutils]"]
=> ["install ok installed binutils 2.30-21ubuntu1~18.04.2 [binutils-gold, elf-binutils]"]
irb(main):005:0> name = "g++"
=> "g++"
irb(main):006:0> lines.find {|package| package.match(/\[.*#{name}.*\]/)}
=> "install ok installed binutils 2.30-21ubuntu1~18.04.2 [binutils-gold, elf-binutils]"

NEW

irb(main):012:0> lines.find {|package| package.match(/\[.*#{Regexp.escape(name)}.*\]/)}
=> nil
irb(main):013:0> name = "binutils-gold"
=> "binutils-gold"
irb(main):014:0> lines.find {|package| package.match(/\[.*#{Regexp.escape(name)}.*\]/)}
=> "install ok installed binutils 2.30-21ubuntu1~18.04.2 [binutils-gold, elf-binutils]"

[puppetcla]

CLA signed by all contributors.

[jtappa]

ping @loopinu this seems related to something you have a PR up for?

[joshcooper]

Thank you for your contribution @treydock! We ended up reverting the dpkg virtual package change and releasing the fix in 6.8.1, so it is no longer necessary to escape the regex. I'm going to close this PR.

We are working on readding dpkg/apt virtual package support, but it will be strictly opt-in, so that 6.x users are not surprised. Please follow our progress in #7701 and give feedback there. It looks like that PR correctly handles regex escaping, such as g++, but it would be great if you could give it a try.

Thanks again!