(PUP-10015) Add support for arbitrary equality to pip provider#7703
Closed
butlern wants to merge 1 commit intopuppetlabs:masterfrom
Closed
(PUP-10015) Add support for arbitrary equality to pip provider#7703butlern wants to merge 1 commit intopuppetlabs:masterfrom
butlern wants to merge 1 commit intopuppetlabs:masterfrom
Conversation
Without this patch the pip provider doesn't correctly parse pip freeze output specified with arbitrary equality. https://www.python.org/dev/peps/pep-0440/#arbitrary-equality This is manifest with triple === separating the package name from the package version, e.g. $ pip freeze | grep pytz pytz===2012f By not correctly parsing this output, puppet tries to continually install this package on each run. The patch updates the regex to handle arbitrary equality.
Collaborator
|
Can one of the admins verify this patch? |
|
CLA signed by all contributors. |
GabrielNagy
approved these changes
Sep 10, 2019
joshcooper
reviewed
Sep 11, 2019
Contributor
|
Verified pytz is only installed once with this change. Previously puppet would install it every time it ran: |
joshcooper
approved these changes
Sep 11, 2019
Contributor
|
Waiting to merge until 6.9.0 tag is created. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch the pip provider doesn't correctly parse pip freeze
output specified with arbitrary equality.
https://www.python.org/dev/peps/pep-0440/#arbitrary-equality
This is manifest with triple === separating the package name from the
package version, e.g.
$ pip freeze | grep pytz
pytz===2012f
By not correctly parsing this output, puppet tries to continually
install this package on each run.
The patch updates the regex to handle arbitrary equality.