(PUP-9940) don't run puppet.bat on starting daemon#7788
Merged
ciprianbadescu merged 1 commit intopuppetlabs:6.4.xfrom Nov 4, 2019
Merged
(PUP-9940) don't run puppet.bat on starting daemon#7788ciprianbadescu merged 1 commit intopuppetlabs:6.4.xfrom
ciprianbadescu merged 1 commit intopuppetlabs:6.4.xfrom
Conversation
Contributor
Author
|
to be merged with: #7781 |
Contributor
Author
|
jenkins please test this on windows2019_core-64 |
|
CLA signed by all contributors. |
Contributor
|
@gimmyxd I think you meant to target 6.4.x? |
Contributor
|
LGTM. Ran procexp on old and new builds, and verified the only environment variable diff are as expected: $ diff old_env.txt new_env.txt
6c6
< COMPUTERNAME MELODIC-REGIME
---
> COMPUTERNAME Y5ZMJE3CYF54NKF
28d27
< PROMPT $P$G
39c38
< USER MELODIC-REGIME$
---
> USER Y5ZMJE3CYF54NKF$
41c40
< USERNAME MELODIC-REGIME$
---
> USERNAME Y5ZMJE3CYF54NKF$Other than then base branch needing to target 6.4.x, I'm 👍 |
GabrielNagy
reviewed
Oct 31, 2019
joshcooper
approved these changes
Oct 31, 2019
Contributor
|
Waiting until Monday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.