Use internal domain name for module tool tests#784
Merged
pcarlisle merged 1 commit intopuppetlabs:2.7.xfrom May 15, 2012
Merged
Conversation
Some tests were intermittently failing when we used the hostname "forge-dev.puppetlabs.com" rather than "forge-dev.puppetlabs.lan", because it was resolving to the external IP address and somehow that was being blocked by the firewall under certain circumstances. This changes them to all use the internal name / IP.
Contributor
|
Wasn't the plan to use forge.puppetlabs.com, the real forge. So that people outside of the office can run this, as can our non PuppetLabs employees? |
Contributor
|
This makes me sad. |
Author
|
@barn: we discussed that and decided that it would be a bad idea. It might be a good idea to have an official "test" forge that was accessible externally, but having our testing directed against the "live"/"production" forge could cause a lot of really big problems. Happy to discuss further. |
pcarlisle
added a commit
that referenced
this pull request
May 15, 2012
…cceptance-failures Use internal domain name for module tool tests
Author
|
for the record, this makes me sad too. :) |
Contributor
|
I must have missed that discussion... |
Author
|
@barn: sorry--we should chat about it soon and if we can come up with a better plan, sweet. I'll ping you about it next time I'm over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests were intermittently failing when we used the hostname
"forge-dev.puppetlabs.com" rather than "forge-dev.puppetlabs.lan",
because it was resolving to the external IP address and somehow
that was being blocked by the firewall under certain circumstances.
This changes them to all use the internal name / IP.