(PUP-10317) Provide better error when hiera-eyaml decryption fails#8005
Merged
jtappa merged 1 commit intopuppetlabs:masterfrom Mar 2, 2020
Merged
(PUP-10317) Provide better error when hiera-eyaml decryption fails#8005jtappa merged 1 commit intopuppetlabs:masterfrom
jtappa merged 1 commit intopuppetlabs:masterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
|
CLA signed by all contributors. |
alexjfisher
force-pushed
the
PUP-10317
branch
from
bb9f0e1 to
a760626
Compare
joshcooper
approved these changes
Feb 28, 2020
Contributor
joshcooper
left a comment
joshcooper
left a comment
There was a problem hiding this comment.
Thanks for your contribution @alexjfisher! IIUC decrypt and decryp_value can't be called from outside of this function, so changing the signature is ok.
Contributor
Author
|
For background, when I started working on this, I was hoping to resolve voxpupuli/hiera-eyaml#214 but this appears very difficult with hiera 5. At least improved logging shows users what they might need to fixup and/or workaround using |
jtappa
approved these changes
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes voxpupuli/hiera-eyaml-gpg#41