(PUP-10496) Fix parsing version range for regular version

[Hexta]

Fix parsing version range for simple version string like '1.2.3'.

Puppet Version: 6.11.0
Puppet Server Version: 6.11.0
OS Name/Version: Debian 9

Steps:
puppet resource package prometheus-client ensure='0.7.1' provider='pip3' --debug

Actual Behavior:
Debug log contains strange string:

Debug: Cannot parse 0.7.1 as a pip version range, falling through.

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[luchihoratiu]

Hi @Hexta! Thank you for using Puppet and showing interest in code contribution, but before reviewing your solution, we would really appreciate getting more information regarding the issue you've come across when using version ranges (such as the package provider used, operating system, package name or any other details that could help us reproduce the problem and manually check your fix against).

We are asking this because the case (as currently explained in your pull request's description) should already be covered by letting each package provider handle simple version string like '1.2.3' their own way. This fallback (from version ranges to default implementation) was intentional (for first revision of the feature at least) due to the complexity and refactoring needed for uniformizing all the package providers to have simple versions (or =version) also fully covered in the added version ranges code.

Cheers!

[Hexta]

@luchihoratiu Hello Luchi!
I've added comments from the JIRA ticket: https://tickets.puppetlabs.com/browse/PUP-10496

[luchihoratiu]

Besides some very small observations, this looks really good. I initially found the changes a bit inconsistent across providers but this is actually due to the current implementation and specifics each have (also double checked and indeed this wouldn’t make sense for the gem provider). They might get a bit more standardised at some point in a future refactoring.

I’ve manually tested the changes for each provider (pip and pip3 on macOS 10.14, apt on Ubuntu 20.04, yum on RedHat 8 and zypper on SLES 15) and they work as expected with previous functionality being unaffected. Thank you again @Hexta for your contribution. Great job!

[Hexta]

@luchihoratiu Thank you for you comments!
I have fixed all issues.

[Dorin-Pleava]

LGTM, and works as expected on Fedora.
One small thing before merging would be to add the JIRA ticket number in the PR title and in the PR commit:
(PUP-10496) Fix parsing version range for regular version

[Hexta]

@Dorin-Pleava I've changed PR title.
The commit already has the ticket number in the title.