(PUP-10527) Test puppet service runs puppet

[johnduarte]

This commit adds an acceptance test to ensure that starting the puppet
service on agents runs puppet. This validation was missing from the
puppet_service_management.rb test. Due to the comprehensive nature of
the existing test, this test is added independently to reduce execution
time. The existing test takes about 4m to execute while this specific
case takes about 30s.

[johnduarte]

This test has been locally validated on el-7 and windows-2012 to:

• Fail on puppet agent f7013c2 which contains puppet with this commit triggering the issue documented in PUP-10527.
• Pass on puppet agent 6.16.0 with contains puppet with this commit to fix the issue.

[johnduarte]

I am not sure what is going on with the windows spec test failure in appveyor. 🤷

[puppetcla]

CLA signed by all contributors.

[GabrielNagy]

For me this fails if the agent didn't run before on the target machine, since the last_run_report file was never there. We should also take this into account.

Maybe an easier way would be to remove the file when starting the test, and after the puppet run to check if it's present. Then we wouldn't need to compare times and whatnot.

Failing output:

Begin tests/resource/service/puppet_service_runs_puppet.rb

Starting the puppet service should successfully run puppet
  
  * Ensure stop puppet service
    
    playable-girth.delivery.puppetlabs.net (playable-girth.delivery.puppetlabs.net) 17:31:50$ cmd.exe /c puppet resource service puppet ensure=stopped
      Warning: Skipping ip method to ssh to host as its value is not set. Refer to https://github.com/puppetlabs/beaker/tree/master/docs/how_to/ssh_connection_preference.md to remove this warning
      Attempting ssh connection to playable-girth.delivery.puppetlabs.net, user: Administrator, opts: {:config=>false, :verify_host_key=>false, :auth_methods=>["publickey"], :port=>22, :forward_agent=>true, :keys=>["id_rsa_acceptance", "~/.ssh/id_rsa-acceptance"], :user_known_hosts_file=>"/home/gabi/.ssh/known_hosts", :keepalive=>true}
verify_host_key: false is deprecated, use :never
      service { 'puppet':
        ensure   => 'stopped',
        provider => 'windows',
      }
    
    playable-girth.delivery.puppetlabs.net (playable-girth.delivery.puppetlabs.net) executed in 5.72 seconds
    
    playable-girth.delivery.puppetlabs.net (playable-girth.delivery.puppetlabs.net) 17:31:55$ cmd.exe /c puppet resource service puppet
      service { 'puppet':
        ensure   => 'stopped',
        enable   => 'manual',
        provider => 'windows',
      }
    
    playable-girth.delivery.puppetlabs.net (playable-girth.delivery.puppetlabs.net) executed in 3.13 seconds
  
  playable-girth.delivery.puppetlabs.net (playable-girth.delivery.puppetlabs.net) 17:31:58$ cmd.exe /c puppet config print statedir
    C:/ProgramData/PuppetLabs/puppet/cache/state
  
  playable-girth.delivery.puppetlabs.net (playable-girth.delivery.puppetlabs.net) executed in 2.50 seconds
  
  playable-girth.delivery.puppetlabs.net (playable-girth.delivery.puppetlabs.net) 17:32:01$ env PATH=":${PATH}" ruby -e 'puts File.stat("C:/ProgramData/PuppetLabs/puppet/cache/state/last_run_report.yaml").mtime.to_i'
    -e:1:in `stat': No such file or directory @ rb_file_s_stat - C:/ProgramData/PuppetLabs/puppet/cache/state/last_run_report.yaml (Errno::ENOENT)
    	from -e:1:in `<main>'
  
  playable-girth.delivery.puppetlabs.net (playable-girth.delivery.puppetlabs.net) executed in 0.75 seconds
  Exited: 1

[GabrielNagy]

jenkins please test this on redhat7-64,ubuntu1804-64,windows2016-64

[puppetcla]

CLA signed by all contributors.