Revert "Merge pull request #8305 from ciprianbadescu/PUP-10598/ignore_plugin_errors#8321
Merged
joshcooper merged 1 commit intopuppetlabs:mainfrom Sep 9, 2020
Merged
Conversation
|
CLA signed by all contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2ec586e, reversing
changes made to 8427686.
The following tests are failing in puppetserver CI, because the agent no longer falls back to its cached catalog if pluginsync fails:
I went ahead and reverted this as we'll need to fix PUP-1763 in 5.5.x and then switch the default value in 7, and didn't want to block puppetserver CI while that happens.