(maint) Fix i18n acceptance tests#8340
Merged
mihaibuzgau merged 1 commit intopuppetlabs:mainfrom Oct 1, 2020
Merged
Conversation
luchihoratiu
force-pushed
the
maint-fix-disable-i18n-acceptance-tests
branch
from
a610b45 to
d251c78
Compare
Contributor
Author
|
jenkins please test this with servertests |
|
CLA signed by all contributors. |
Contributor
|
Needs rebase on upstream/main to get the rubocop fix in c3a37a9 |
luchihoratiu
force-pushed
the
maint-fix-disable-i18n-acceptance-tests
branch
2 times, most recently
from
173f51f to
c152b03
Compare
During the change of disable_i18n's default value from false to true there have been reactivated multiple acceptance tests. One of those tests, tests/i18n/modules/puppet_agent.rb, was failing constantly on the first run and passing after. This was due to puppetserver's load of puppet.conf configuration file in memory at the service's startup. This was fixed by ensuring the desired disable_i18n value before restarting the puppetserver service and doing proper test teardown by reverting it to the original/default value. All i18n acceptance tests have been adapted in the same way.
luchihoratiu
force-pushed
the
maint-fix-disable-i18n-acceptance-tests
branch
from
c152b03 to
94990bf
Compare
Contributor
Author
|
Rebased to include the Rubocop fix and after discussing with the team, we decided to leave only the |
Contributor
|
jenkins please test this with servertests |
gimmyxd
approved these changes
Sep 30, 2020
Contributor
Author
|
jenkins please test this with servertests |
1 similar comment
Contributor
Author
|
jenkins please test this with servertests |
Contributor
Author
|
jenkins please test this with servertests |
luchihoratiu
force-pushed
the
maint-fix-disable-i18n-acceptance-tests
branch
from
d03dba6 to
94990bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the change of
disable_i18n's default value fromfalsetotruethere have been reactivated multiple acceptance tests. One of those tests,tests/i18n/modules/puppet_agent.rb, was failing constantly on the first run and passing after. This was due to puppetserver's load ofpuppet.confconfiguration file in memory at the service's startup.This was fixed by ensuring the desired
disable_i18nvalue before restarting thepuppetserverservice and doing proper test teardown by reverting it to the original/default value. All i18n acceptance tests have been adapted in the same way.