(#15398) fix typo in Scope#number? float detection regex#908
Closed
masterzen wants to merge 1 commit intopuppetlabs:masterfrom
Closed
(#15398) fix typo in Scope#number? float detection regex#908masterzen wants to merge 1 commit intopuppetlabs:masterfrom
masterzen wants to merge 1 commit intopuppetlabs:masterfrom
Conversation
This allowed incorrect numbers (like 2:.34) to be recognized as floats (with an incorrect value). Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
Contributor
|
Ah the inner nested paren was supposed to be a non-capturing parenthesis... |
Contributor
Author
|
Definitely, but I was certainly blind when I initially wrote the code :) |
Contributor
|
Rebased/merged to 3.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allowed incorrect numbers (like 2:.34) to be recognized as
floats (with an incorrect value).