Fix storedconfig tests for 1886 and reenable them#92
Merged
slippycheeze merged 2 commits intopuppetlabs:2.7.xfrom Jan 10, 2012
Merged
Fix storedconfig tests for 1886 and reenable them#92slippycheeze merged 2 commits intopuppetlabs:2.7.xfrom
slippycheeze merged 2 commits intopuppetlabs:2.7.xfrom
Conversation
This reverts commit 38801dd.
We didn't properly call the method to test, which lead to a failing test. However, this couldn't be properly displayed on ruby installations with an ActiveRecord 3.x installed, as the inspect in the `after test` part, tried to examine the table, which (obviuosly) raised a NotConnected exception. By calling the method the right way, we fix the test and hence also fix the failing inspection.
Contributor
Author
|
What's the current status of this review and what needs to be done, that this gets merged in the next release? |
Contributor
|
This was pending someone being able to review and merge it, rather than anything external; it seems to work correctly, so I am going to merge it and check that it doesn't break on the entire test suite. |
slippycheeze
added a commit
that referenced
this pull request
Jan 10, 2012
Fix storedconfig tests for 1886 and reenable them
hlindberg
pushed a commit
to hlindberg/puppet
that referenced
this pull request
Oct 16, 2014
Fixed #12391 - Addressed mention of erroneous PE 1.2.5 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make that feature now properly available and tests should run on all (?) ruby platforms.
At least I ran tests with 1.8.5 (activerecord 2.3.x), 1.8.7 (activerecord 2.3.x) and 1.9.2 (activerecord 3.1.x). In the past they were only failing on the last one. So hopefully we fixed things now.
~pete