(#15668) Don't pluginsync for apply#968
Merged
pcarlisle merged 3 commits intopuppetlabs:3.xfrom Aug 2, 2012
Merged
Conversation
After trying out having apply pluginsync there have been several unwanted side effects. This commit removes the apply command from pluginsyncing and so leaves only agent and device still performing pluginsync.
Previously the Configurer took a parameter, :skip_plugin_download, which whould cause it to not trigger a pluginsync. At the same time the pluginsync code (Downloader) would look at Puppet[:pluginsync] to decide whether it should actually pluginsync or not. This changes it so that there is only Pupppet[:pluginsync] which is passed through to the Configurer as a :pluginsync parameter when the Configurer is called. Now all callers can be explicit about doing the pluginsync and the Configurer is less dependent on Puppet settings.
Contributor
There was a problem hiding this comment.
This is the only test that checks the ordering of files in the plugin mount. That should be preserved somehow, using master/agent or the plugin face.
The previous version of this test relied on using puppet apply to check that the module path order was preserved in deciding the files to use from a pluginsync. Without apply performaning a pluginsync that was not possible anymore, but this test is still useful. This replaces the previous test with a new one that uses the master and the agent for performing a pluginsync and checking what files the agent recieves.
pcarlisle
added a commit
that referenced
this pull request
Aug 2, 2012
* github.com:puppetlabs/puppet: (#15668) Replace test for order of files in pluginsync (#15668) Use only one way of triggering pluginsync (#15668) Don't pluginsync for apply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After trying out having apply pluginsync there have been several unwanted
side effects. This commit removes the apply command from pluginsyncing and
so leaves only agent and device still performing pluginsync.
In addition this also pulls out the configurer's dependency on
Puppet[:pluginsync]so that there is only one way of controlling whether theConfigurer will pluginsync.