(#7175) ensure ensurable uses symbols in zone

[vrthra]

zone provider when asked to ensure the state to running/install or any
thing tries to find the value in state_index however, state_index values
stores keys as string. This is wrong. The root cause is that
ensurable returns values as string rather than symbols. This inturn is
caused by state_name checking for string value in state_alias which is a
symbol to symbol map, and not finding any, and returning itself.

[vrthra]

@joshcooper updated the test cases with positive and negative test cases of state_name.

[joshcooper]

@vrthra also puppet has the capability to define aliases for parameter values, e.g. the file type does:

  newparam(:replace, :boolean => true) do
    ...
    newvalues(:true, :false)
    aliasvalue(:yes, :true)
    aliasvalue(:no, :false)
    defaultto :true
  end

This may simplify the different states that you are trying to alias (assuming the states are possible ensure values)

[vrthra]

Postponing the newparam work (and other issues) to 15886

[joshcooper]

Merged in commit af762d8