(#15521) Convert to using host stub wrapper#984
Merged
joshcooper merged 1 commit intopuppetlabs:2.7.xfrom Aug 13, 2012
Merged
Conversation
This patch converts the module acceptance code to using the host stub wrapper now provided in puppet-acceptance: `stub_forge_on`. This will allow us to change the forge host we are stubbing dynamically as apposed to manually changing it everywhere in acceptance code. This also changes the cases where we have teardown code to use the new `teardown` block, and to use `rm -rf` for file cleanup to avoid puppet backup duplication issues.
Contributor
Author
|
@joshcooper if you have time, can you take a look at this again? Thanks mate. |
Contributor
|
@kbarber will do today |
Contributor
|
@kbarber actually, we're working through some function issues in 2.7.x, so whenever that gets cleared up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this depends on the following pull request to be merged first:
https://github.com/puppetlabs/puppet-acceptance/pull/260
This patch converts the module acceptance code to using the host stub wrapper
now provided in puppet-acceptance:
stub_forge_on.This will allow us to change the forge host we are stubbing dynamically as
apposed to manually changing it everywhere in acceptance code.
This also changes the cases where we have teardown code to use the new
teardownblock.