(#8288) pkgadd - allow user to specify -G#993
Closed
vrthra wants to merge 4 commits intopuppetlabs:3.xfrom
vrthra:ticket/3.x/8288_pkgadd_G
Closed
(#8288) pkgadd - allow user to specify -G#993vrthra wants to merge 4 commits intopuppetlabs:3.xfrom vrthra:ticket/3.x/8288_pkgadd_G
vrthra wants to merge 4 commits intopuppetlabs:3.xfrom
vrthra:ticket/3.x/8288_pkgadd_G
Conversation
In ruby we can avoid the extra syntactic noice of parenthesis in method calls with no arguments
- refactor the namemap completely so that it is defined only once * We also remove the nil lines so that only keys of interest are retained. - replace the execpipe with execute since we do not want to exit only halfway through - refactor the info2hash to parse_pkg and replace the instances and info2hash to use it instead of duplicating the code - cleanup the exception handling to ensure that an exception is used only when it really is an exception. - IMP: This fixes the bug * changing from execpipe to execute removes the problem that we were facing, that is, execpipe block used to return an array as output which used to cause the exception that was raised to have an array as the error message. * We no longer rely on exception handling to know when a package is not present. Instead we parse the ouput and look for 'ERROR' string.
This ensures that the logic of deciding what extra options to pass are in one place.
Before implementing this feature, pkgadd solaris could not
specify { install_options=>options } as extra options in package
manifest for puppet. This checkin adds the :install_option feature to
the provider which enables the use of { install_options=> options }
parameter. This checkin also adds the test cases for this feature.
Contributor
|
Now that 15868 was merged, I rebased this on 3.x, resolved some conflicts and merged it as b4f508f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on merge of ticket/3.x/15686_s10_resource_failure