mod proxy class does not allow array of IP addresses in param allow_from

[jmcnatt]

Describe the Bug

Class apache::mod::proxy parameter allow_from expects a string, but should accept a list (array) of IP addresses.

Error:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Class[Apache::Mod::Proxy]: parameter 'allow_from' expects a value of type Undef or String, got Tuple

Expected Behavior

An array of IPs should be accepted, either through hiera or through resource-style declaration.

Steps to Reproduce

Steps to reproduce the behavior:

1. Add the following to a profile:

include apache

class { 'apache::mod::proxy':
  allow_from => [
    '192.168.0.1',
    '192.168.0.2',
  ],
}

Environment

• Module version: 8.4.0
• Platform: CentOS 7

Additional Context

The issue surfaced with this commit that specifically typed the params.

The template proxy.conf.erb even references an array to split.

[ekohl]

Sounds like a regression indeed. The parameter documentation also says "list of IPs". Could you come up with a patch?

[pebtron]

I can confirm this is broken on RHEL7 + module version 9.0.1. templates/mod/proxy.conf.erb assumes allow_from is an array when manifests/mod/proxy.pp specifies it to be of type Stdlib::IP::Address.

[david22swan]

Fix has been merged in, should be release by end of day