pdksync - (maint) PDKSync - PDK Update #2156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jun 7, 2021
Comment on lines
+52
to
+62
| # Filter backtrace noise | ||
| backtrace_exclusion_patterns = [ | ||
| %r{spec_helper}, | ||
| %r{gems}, | ||
| ] | ||
|
|
||
| if c.respond_to?(:backtrace_exclusion_patterns) | ||
| c.backtrace_exclusion_patterns = backtrace_exclusion_patterns | ||
| elsif c.respond_to?(:backtrace_clean_patterns) | ||
| c.backtrace_clean_patterns = backtrace_exclusion_patterns | ||
| end |
Collaborator
There was a problem hiding this comment.
Shouldn't this be contributed to https://github.com/puppetlabs/puppetlabs_spec_helper?
Contributor
Author
There was a problem hiding this comment.
Hi @ekohl,
For now we will keep these changes in the pdk-templates and if this works out nicely for the currently supported modules then we will probably port it to the puppetlabs_spec_helper and this change will be removed on a future pdk update.
michaeltlombardi
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(maint) PDKSync - PDK Update
pdk version:
2.1.0