(MODULES-10945) Core module spring cleaning 2021 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add beaker-puppet to unify core module gemfiles
Create a separate group in the Gemfile for pdk and puppet-blacksmith which are only used for releasing. In the workflow, avoid installing the release group.
Pin puppet-module-posix-system and puppet-module-win-system to an older version since the newer ones do not bundle some gems that we use in acceptance (i.e. beaker-module_install_helper), causing tests to fail.
Update the workflow that tests with released Puppet gems to also test with Puppet 7. Remove testing with Puppet 5 from the workflows since it reached EOL.
Bump Ruby version in the static code analysis workflow to 2.6, as 2.5 will be EOL soon.
luchihoratiu
approved these changes
Feb 18, 2021
BobosilaVictor
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a separate group in the
Gemfileforpdkandpuppet-blacksmithwhich are only used for releasing. In the workflow, avoid installing the release group.Pin
puppet-module-posix-systemandpuppet-module-win-systemto an older version since the newer ones do not bundle some gems that we use in acceptance (i.e.beaker-module_install_helper), causing tests to fail.Update the workflow that tests with released Puppet gems to also test with Puppet 7.
Bump Ruby version in the static code analysis workflow to 2.6, as 2.5 will be EOL soon.
Remove testing with Puppet 5 from the workflows since it reached EOL.
Add
beaker-puppetto the Gemfile since other core modules have it.