(maint) pdk convert #588
Merged
(maint) pdk convert #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciprianbadescu
force-pushed
the
maint/pdk-convert
branch
5 times, most recently
from
dd82cba to
b8a2ae8
Compare
| 'include puppet_agent::params', | ||
| 'include puppet_agent', | ||
| ] | ||
| 'include puppet_agent'] |
There was a problem hiding this comment.
Weird that rubocop chose to close the square bracket here. Maybe if there is a new line after [ it will want ] on a seperate line also?
There was a problem hiding this comment.
I think it depends on how the first line of array looks like, will try to fix that
ciprianbadescu
force-pushed
the
maint/pdk-convert
branch
from
b8a2ae8 to
bc6c420
Compare
ciprianbadescu
commented
Jan 12, 2022
ciprianbadescu
commented
Jan 12, 2022
ciprianbadescu
force-pushed
the
maint/pdk-convert
branch
3 times, most recently
from
d7a59e5 to
ad597a7
Compare
GabrielNagy
added
the
maintenance
GabrielNagy
approved these changes
Jan 20, 2022
ciprianbadescu
force-pushed
the
maint/pdk-convert
branch
from
ad597a7 to
494ce6d
Compare
added 6 commits
January 20, 2022 14:13
save `commits` and `gen_nodeset` in `rakelib`
adapt spec helpers to keep the existing setup
Adding back gems needed to run acceptance tests Delete not needed file `spec/default_facts.yml`
* save existing changelog to HISTORY.md
* configure changelog generator to generate new entries
starting with 4.9.0 tag
* pin octokit to 4.21.0 since we hit the issue at octokit/octokit.rb#1391
* pin async to ~> 1.30 otherwise async 2.0.0(needs ruby >=3.1.0) is wrongly selected by
bundler on jenkins while running with ruby 2.7.1
ciprianbadescu
force-pushed
the
maint/pdk-convert
branch
from
494ce6d to
99d7dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.