Skip to content

Conversation

@DavidS
Copy link
Contributor

@DavidS DavidS commented Nov 24, 2020

No description provided.

@DavidS DavidS self-assigned this Nov 24, 2020
@DavidS DavidS requested a review from a team as a code owner November 24, 2020 11:28
@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #1142 (73ab8ae) into main (121c5eb) will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #1142      +/-   ##
========================================
+ Coverage   4.68%   5.60%   +0.91%     
========================================
  Files        186     186              
  Lines       5230    5230              
========================================
+ Hits         245     293      +48     
+ Misses      4985    4937      -48     
Impacted Files Coverage Δ
lib/puppet/type/file_line.rb 96.36% <0.00%> (+1.81%) ⬆️
lib/puppet/provider/file_line/ruby.rb 62.62% <0.00%> (+47.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 121c5eb...73ab8ae. Read the comment docs.

On the new CI machines, there is no local Administrator account, hence
this test would fail without merit.

This change fixes the tests to use a fresh directory and create it at the
start of the test suite.
@carabasdaniel carabasdaniel merged commit 0170314 into puppetlabs:main Nov 25, 2020
@DavidS DavidS deleted the cloudci branch November 25, 2020 12:50
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.60%. Comparing base (121c5eb) to head (73ab8ae).
Report is 561 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1142      +/-   ##
========================================
+ Coverage   4.68%   5.60%   +0.91%     
========================================
  Files        186     186              
  Lines       5230    5230              
========================================
+ Hits         245     293      +48     
+ Misses      4985    4937      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants