(MAINT) CI Updates #197
Merged
(MAINT) CI Updates #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a few bugs and also refreshes the workflows so they are inline with the reusable workflow templates. Note: this repo is an exception and cannot use the reusable workflows because it contains a library and a Puppet module. To avoid duplication and conflicts the workflows are defined explicitly here.
chelnak
force-pushed
the
maint-update_ci
branch
from
def0897 to
b0aae1c
Compare
Prior to this commit spec.files used git to collect the required files for the gem. This would pull in everything that had been checked in to git. We can actually be a little bit more explicit here. This commit updates spec.files to contain a known list of files to include in the gem.
chelnak
force-pushed
the
maint-update_ci
branch
from
b0aae1c to
5eda23d
Compare
LukasAud
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of fixes and improvements for the workflows in this project.