Pooler.modify raises exception if Token is nil

[briancain]

If no token is provided to the modify class, vmfloaty sets the token in the header to be nil. Instead, vmfloaty should raise an exception since modifying a vm without a token is not allowed in vmpooler.

brian@localhorse:~ % floaty modify p2j0rut80kqewbq.delivery.puppetlabs.net --lifetime 10 --trace
/Users/brian/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/header.rb:17:in `block in initialize_http_header': undefined method `strip' for nil:NilClass (NoMethodError)
    from /Users/brian/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/header.rb:15:in `each'
    from /Users/brian/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/header.rb:15:in `initialize_http_header'
    from /Users/brian/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http/generic_request.rb:43:in `initialize'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:62:in `new'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:62:in `create_request'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:82:in `perform_request'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:40:in `block in call'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:87:in `with_net_http_connection'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:32:in `call'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/request/url_encoded.rb:15:in `call'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/rack_builder.rb:139:in `build_response'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/connection.rb:377:in `run_request'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/faraday-0.9.2/lib/faraday/connection.rb:177:in `put'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/vmfloaty-0.7.0/lib/vmfloaty/pooler.rb:69:in `modify'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/vmfloaty-0.7.0/lib/vmfloaty.rb:180:in `block (2 levels) in run'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/commander-4.4.0/lib/commander/command.rb:178:in `call'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/commander-4.4.0/lib/commander/command.rb:178:in `call'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/commander-4.4.0/lib/commander/command.rb:153:in `run'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/commander-4.4.0/lib/commander/runner.rb:444:in `run_active_command'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/commander-4.4.0/lib/commander/runner.rb:68:in `run!'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/commander-4.4.0/lib/commander/delegates.rb:15:in `run!'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/vmfloaty-0.7.0/lib/vmfloaty.rb:456:in `run'
    from /Users/brian/.rvm/gems/ruby-2.2.3/gems/vmfloaty-0.7.0/bin/floaty:7:in `<top (required)>'
    from /Users/brian/.rvm/gems/ruby-2.2.3/bin/floaty:23:in `load'
    from /Users/brian/.rvm/gems/ruby-2.2.3/bin/floaty:23:in `<main>'
    from /Users/brian/.rvm/gems/ruby-2.2.3/bin/ruby_executable_hooks:15:in `eval'
    from /Users/brian/.rvm/gems/ruby-2.2.3/bin/ruby_executable_hooks:15:in `<main>'

[briancain]

/cc @cbrock for finding this 👍

[briancain]

Pushed a fix, gonna test it when I have vpn access because apparently my cert expired 👍