SSH Command respects ABS now and tests should fail if the API changes…

[mikkergimenez]

… again

Proof

❰mikker❙~/Dev/vmfloaty(git:fix_ssh_command_breaking)❱✔≻ bin/floaty ssh ubuntu-1604-x86_64 --trace --service vmpooler
The authenticity of host 'blocky-armor.delivery.puppetlabs.net (10.16.115.120)' can't be established.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'blocky-armor.delivery.puppetlabs.net,10.16.115.120' (ECDSA) to the list of known hosts.
root@blocky-armor.delivery.puppetlabs.net's password:
❰mikker❙~/Dev/vmfloaty(git:fix_ssh_command_breaking)❱✘≻ bin/floaty ssh ubuntu-1604-x86_64 --trace --service abs
Requesting VMs with job_id: 1580167494644. Will retry for up to an hour.
Waiting 1 seconds to check if ABS request has been filled. Queue Position: 144... (x1)
Waiting 2 seconds to check if ABS request has been filled. Queue Position: 144... (x2)
Waiting 3 seconds to check if ABS request has been filled. Queue Position: 143... (x3)
The authenticity of host 'close-poison.delivery.puppetlabs.net (10.16.118.16)' can't be established.
Are you sure you want to continue connecting (yes/no)? no

Status

Ready for Merge

Description

The SSH Command was broken because the vmpooler api changed but it wasn't changed in the ssh command. This PR:

• changes the ssh command to use the service object instead of the vmpooler object so it will work with ABS
• adds tests to ensure that this code path will alert if an API changes again.

Related Issues

Todos

• Tests
• Documentation

Reviewers

@demophoon
@briancain

[highb]

👍 Works in my testing.