Skip to content

Add params to MatchClass #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2016
Merged

Add params to MatchClass #17

merged 1 commit into from
Jan 15, 2016

Conversation

@jonsterling
Copy link
Contributor

  • Added params to MatchClass, which will capture a whole block of parameters as a map
  • Updated the build deps
  • Fixed a couple warnings
  • Regenerated docs

@cryogenian
Copy link
Member

Awesome! 👍
Could you, please, mention somewhere in docs that foo/ isn't matched with string "foo" *> params?

@cryogenian cryogenian assigned jonsterling and unassigned cryogenian Jan 15, 2016
@jonsterling
Copy link
Contributor Author

@cryogenian Thanks!

  • I'll add the note to the documentation, good idea

@jonsterling
Add params to MatchClass
c43187a 
- Routing.Match.Class: add params method to consume full query
- Fix compiler warnings
- Demonstrate use of `params` in example
- Regenerate docs
- Add documentation to Routing.Match.Class
jonsterling added a commit that referenced this pull request Jan 15, 2016
@jonsterling
Merge pull request #17 from jonsterling/add-match-params
a1f57c6 
Add `params` to `MatchClass`
@jonsterling jonsterling merged commit a1f57c6 into purescript-contrib:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jonsterling jonsterling

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsterling @cryogenian