Add UnsafeRefEq and UnsafeRefEqFallback newtypes with Eq instances #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiamGoodacre
referenced
this pull request
in purescript/purescript-prelude
Sep 19, 2018
Running Eq on large nested data structures can be expensive (think rose trees with 10^5 items), so checking for reference equality before traversing the array can result in some significant gains.
garyb
approved these changes
Sep 19, 2018
Member
Author
|
Not sure what's going on on travis. Looks like it tried to build before installing bower dependencies? |
Member
Author
|
OH, we only depend on prelude as a dev dependency! oops! |
Member
|
It's probably fine to add that, despite it technically being breaking... maybe? 😄 |
Member
Author
|
Added the dependency on |
|
Any progress on this? Also, |
Contributor
|
Coming back around to this -- I don't see any reason not to merge this in and do a release. This is a nice thing to have. @LiamGoodacre, @garyb, do you have any objections to merging? |
thomashoneyman
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5
I've added two different variations on the newtype:
UnsafeRefEqwhich only usesunsafeRefEqas it'sEqimplementationUnsafeRefEqFallbackwhich first checksunsafeRefEq, but falls back to the underlyingEqinstance