Skip to content

Fix select bugs: filter selected options, avoid re-render on focus change #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2021
Merged

Fix select bugs: filter selected options, avoid re-render on focus change #182

merged 1 commit into from
Jan 13, 2021

Conversation

@maddie927
Copy link
Member

@maddie927 maddie927 commented Jan 12, 2021

Related: https://gitlab.com/lumi-tech/lumi/-/issues/5658

  • the native input no longer disappears during the mousedown event of selecting an option, keeping the option under the cursor for the mouseup/click event, allowing the selection to complete
  • selected options no longer appear in the option list

@kimispencer kimispencer self-requested a review January 13, 2021 13:26
arthurxavierx
arthurxavierx reviewed Jan 13, 2021
View reviewed changes
@maddie927 maddie927 merged commit 836a4e3 into main Jan 13, 2021
@maddie927 maddie927 deleted the madeline/fix-select-bugs branch January 13, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@arthurxavierx arthurxavierx arthurxavierx left review comments

@kimispencer kimispencer kimispencer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kimispencer kimispencer

@arthurxavierx arthurxavierx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maddie927 @kimispencer @arthurxavierx