Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 12, 2014

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a little simpler to implement Composite -> String and then define setGlobalCompositeOperation by composition.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an instance for Show Composite originally this was a new class ToJS (essentially identical to Show here) but I had removed it when I saw the existing pattern for setLineCap above.

@paf31
Copy link
Contributor

paf31 commented Sep 12, 2014

👍 Looks great, thanks!

paf31 added a commit that referenced this pull request Sep 12, 2014
Add global composite and alpha functions
@paf31 paf31 merged commit 817e046 into purescript-web:master Sep 12, 2014
@paf31
Copy link
Contributor

paf31 commented Sep 12, 2014

Now would probably be a good time to hide some of the 'impl' methods as well, using a module exports list.

I'll probably make a new release soon as well, unless you have any other changes?

@ghost
Copy link
Author

ghost commented Sep 12, 2014

Nothing further. Those changes were required for something I was working
on. If I hit into anything else I'll make a PR.

On Sat, Sep 13, 2014 at 7:01 AM, Phil Freeman notifications@github.com
wrote:

Now would probably be a good time to hide some of the 'impl' methods as
well, using a module exports list.

I'll probably make a new release soon as well, unless you have any other
changes?


Reply to this email directly or view it on GitHub
#6 (comment)
.

@paf31
Copy link
Contributor

paf31 commented Sep 12, 2014

Sounds good, thanks.

@ghost ghost deleted the global-composite branch September 13, 2014 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant