Add ShadowRoot module #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I am proposing this addition since I was experimenting with shadow-root and custom elements in PureScript. Not sure if all this makes sense to you, since I am not an expert with this technology and its libraries. |
|
Closing since the build fails and at the moment I am not able to troubleshoot. |
|
The build was failing due to this line not being |
|
Thank you for your help. I have created a new PR including the change you mentioned. Now all checks are green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic implementation of the shadow-root functionality, as per DOM standard.
The function
attachShadowis a binding to the corresponding DOM JavaScript function describedon MDN.