Skip to content

Conversation

@klntsky
Copy link
Collaborator

@klntsky klntsky commented Aug 7, 2019

Working on: #15, #16.

updated: package-set
added: `build-dev` script to package.json for faster builds
@klntsky klntsky changed the title Changes for v0.0.5 Changes for v0.0.5 [WIP] Aug 7, 2019
klntsky added 7 commits August 8, 2019 10:21
https://travis-ci.com/spacchetti/starsuit/jobs/229423445#L2489

Fix missing kind annotations in foralls for type class members

E.g. Before:

reifyKeyAndValueSymbols' :: forall f l. ReifyKeyAndValueSymbols l => f l -> List (Tuple String String)

After:

reifyKeyAndValueSymbols' :: forall (f :: RowList -> Type) l. ReifyKeyAndValueSymbols l => f l -> List (Tuple String
String)

Swap arguments in ForAll constructor of Type
@f-f
Copy link
Member

f-f commented Sep 5, 2019

@klntsky can this be merged already?

@klntsky
Copy link
Collaborator Author

klntsky commented Sep 6, 2019

Nope, sorry.

@klntsky
Copy link
Collaborator Author

klntsky commented Sep 6, 2019

I am going to add correct sorting for packages and declarations (packages should appear first), and also sorting by popularity.

@f-f
Copy link
Member

f-f commented Sep 6, 2019

Cool! Though what I meant above was "is there something obviously broken that would prevent this stuff from being in master? (i.e. we can always have another PR for new things)

@klntsky klntsky merged commit 1681ac7 into master Sep 6, 2019
@klntsky klntsky deleted the version-0.0.5 branch September 6, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants