Fix Data.List.Lazy iterate #141
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution of #140
Here's the result of the modification of
iterate.All the values are evaluated exactly once.
It still has a bug. Because the result of
take 3 lazylshould beNot
But the bug is made by
take(as #138), notiterate. So we have nothing to do with this.Just to be sure, I made a performance comparison between the before and after of
iterate.It is made by compiling the purescript code into javascript, and then run the benchmark by Benchmark.js.
Each value in this benchmark is the time of the calculation
sum $ take n $ iterate (_ + 1) 1, wherenis the length of list in the benchmark.The old
iteratehas no value after length > 5000, because it throws exceptions by maximum call stack size exceeded. Yes, it is not stack-safe.The old
iteraterun extremely slow in PSCi (time complexity is not linear), but (I don't know why) it is not bad (except the stack overflow) in this benchmark.