Skip to content

Conversation

@JordanMartinez
Copy link
Contributor

Description of the change

Backlinking to purescript/purescript#4244

Migrates FFI to ES modules


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. labels Mar 14, 2022
@JordanMartinez
Copy link
Contributor Author

Note: This PR will fail to build due to the below error:

* Running tests...
file:///home/jordan/Programming/ps-libs/purescript/purescript-numbers/output/Data.Number/foreign.js:4
export {Infinity as infinity};
        ^^^^^^^^^^^^^^^^^^^^

SyntaxError: Export 'Infinity' is not defined in module
    at ESMLoader.moduleStrategy (node:internal/modules/esm/translators:139:18)
    at ESMLoader.moduleProvider (node:internal/modules/esm/loader:236:14)
* ERROR: Subcommand terminated with exit code 1

@JordanMartinez
Copy link
Contributor Author

CI builds now that the FFI issue has been addressed.

@JordanMartinez JordanMartinez merged commit 16acdf3 into purescript:master Mar 14, 2022
@JordanMartinez JordanMartinez deleted the es-modules-libraries branch March 14, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants