Skip to content

Conversation

@paf31
Copy link
Contributor

@paf31 paf31 commented Dec 16, 2015

This fixes an issue with repeatable which basically made all tests for HOFs equivalent 😱

@paf31
Copy link
Contributor Author

paf31 commented Dec 16, 2015

checkMonadPlus fails for Maybe now 😄

Sometimes it fails, sometimes not. I'd guess it probably takes about 2000 tests on average.

@garyb
Copy link
Member

garyb commented Dec 16, 2015

👍

Glad that's sorted out. Failing that infrequently is about what it was doing in the past also, maybe we should weight Nothing:Just to be more biased towards Just? I don't know if that would help really though.

I guess we should indeed remove that instance.

paf31 added a commit that referenced this pull request Dec 16, 2015
@paf31 paf31 merged commit 8edf244 into master Dec 16, 2015
@paf31 paf31 deleted the repeatable branch December 16, 2015 17:05
@paf31
Copy link
Contributor Author

paf31 commented Dec 16, 2015

I guess we should indeed remove that instance.

Yes, and I also like @hdgarrood 's suggestion of pulling out a MonadZero class. We could maybe add MonadOr at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants