Skip to content

tweaks to github job processing #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f-f merged 2 commits into from
Jan 31, 2026
Merged

tweaks to github job processing #736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51e7652
update github job parsing
thomashoneyman Jan 31, 2026
e137b15
fix commenting and error reporting
thomashoneyman Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions app/src/App/GitHubIssue.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,10 @@ initializeGitHub = do
NotJson ->
pure Nothing

DecodedOperation _ "pacchettibotti" _ -> do
Console.log "Skipping operation from pacchettibotti to avoid feedback loops."
pure Nothing

MalformedJson issue err -> do
let
comment = String.joinWith "\n"
Expand Down Expand Up @@ -340,12 +344,21 @@ readOperation eventPath = do
let hasKeys = all (flip Array.elem keys)
if hasKeys [ "packages" ] then
map (Left <<< PackageSetUpdate) (CJ.decode Operation.packageSetUpdateCodec json)
else if hasKeys [ "name", "ref", "compiler" ] then
else if hasKeys [ "name", "ref", "version" ] then
map (Right <<< Publish) (CJ.decode Operation.publishCodec json)
else if hasKeys [ "payload", "signature" ] then
map (Right <<< Authenticated) (CJ.decode Operation.authenticatedCodec json)
else
Left $ CJ.DecodeError.basic "Operation: Expected a valid registry operation, but provided object did not match any operation decoder."
Left $ CJ.DecodeError.basic $ String.joinWith "\n"
[ "Could not match JSON keys to a registry operation."
, ""
, "Received keys: " <> String.joinWith ", " keys
, ""
, "Expected one of:"
, " - Package set update: { packages, compiler? }"
, " - Publish: { name, ref, compiler, version, location?, resolutions? }"
, " - Authenticated (unpublish/transfer): { payload, signature }"
]

case JSON.parse (JsonRepair.tryRepair (firstObject body)) of
Left err -> do
Expand Down