Skip to content

Conversation

@JamesKoenig
Copy link
Contributor

Description of the change

Currently the Readme's links for VScode (on line 1628) and the LSP server (on line 1630) both are erroneous (on github they attempt to open non-existing files that result in a 404),

These changes to README.md fix them via:

  1. The following []() url links are changed to [][] reference links so they resolve to the references at the end of the document:
    • [Purescript IDE](purescript-ide) -> [Purescript IDE][purescript-ide]
    • [LSP plugin](purescript-language-server) -> [LSP plugin][purescript-language-server]
  2. The following reference typos arecorrected:
    • purescript-ide in the link [Purescript IDE] was changed to match the ide-purescript reference in the references table, as well as the url the reference points to.
    • purescript-langugage-server in the references table was corrected to remove the extra g to make it purescript-language-server to match the url, the reference in the [LSP Plugin] link, and proper english spelling.

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

fixes are:
  1. The following `[]()` url links should've been `[][]` reference
     links:
        - `[Purescript IDE](purescript-ide)`
        - `[LSP plugin](purescript-language-server)`
  2. The following typos were corrected:
        - `purescript-ide` in the link `[Purescript IDE]` was changed to
          match the `ide-purescript` reference in the references table
        - `purescript-langugage-server` was corrected to remove the
          extra g to make it `purescript-language-server` to match the
          url, the reference in the `[LSP Plugin]` link, and proper
          english spelling.
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@f-f f-f merged commit 87e0599 into purescript:master Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants