Fix hlint warnings #450
Merged
Fix hlint warnings #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Oct 8, 2019
|
|
||
| -- | Given a list of filepaths, find the one with the least folders | ||
| findRootPath :: [System.IO.FilePath] -> Maybe System.IO.FilePath | ||
| findRootPath paths |
Contributor
Author
There was a problem hiding this comment.
The only change not suggested by hlint, but I couldn't resist to simplify this to more readable one-liner..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
I fixed relatively conservative subset of hlint warnings which IMO make the code more lightweight/readable by removing some redundancies (unnecessary parens, import aliases, using better functions where available etc.)
Checklist:
README