Switch all the logging to RIO #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does this cover all the cases for application output vs application logging that you described, or is there still more work to be done with respect to logging? |
Member
Author
|
@Benjmhart initially I thought I'd just introduce the library here and then we could switch the logging in a separate PR, but things kind of snowballed (because of porting the test fixtures to the new format) so I guess I'll tackle everything in this PR 😄 |
This was referenced Nov 7, 2019
Closed
Closed
Merged
f-f
added a commit
that referenced
this pull request
Apr 14, 2020
This (rather large, sorry for that) refactoring completes the work of introducing RIO that started in #486 The reason for this PR is to tidy up the "execution requirements" of every command - i.e. what does every command need in order to run. For how the code is structured now this will allow us to request "capabilities" in functions where we need them. Example: there's now a `HasPurs` typeclass that gives the path of the compiler. If there's no `purs` we now fail right at the beginning with a decent error message, rather than deep in the execution tree when we actually need to run it. This is a breaking change because it removes the deprecated `--no-share-output` flag for build commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
riolibrary, mostly to rehaul our logging situation: this replaces ourlogDebug/logError/etc. with rio's own functions.This is to reduce the amount of code that we have to write here to support logging, and to get some logging goodies for free, e.g. colors and timestamps in debug logs.
Sample of the new logging format:
cc @Benjmhart: this introduces a
logInfothat logs tostderr, so we can still useoutputfor outputting tostdout