This commit contains changes for releasing v1.10.0 of the Python REST SDK#33
Merged
tlewis-ps merged 1 commit intopurestorage:masterfrom Oct 13, 2020
tlewis-ps:master
Merged
This commit contains changes for releasing v1.10.0 of the Python REST SDK#33tlewis-ps merged 1 commit intopurestorage:masterfrom tlewis-ps:master
tlewis-ps merged 1 commit intopurestorage:masterfrom
tlewis-ps:master
Conversation
tlewis-ps
commented
Oct 5, 2020
tlewis-ps
commented
Oct 5, 2020
tlewis-ps
commented
Oct 5, 2020
tlewis-ps
commented
Oct 5, 2020
tlewis-ps
commented
Oct 5, 2020
bsamz-ps
reviewed
Oct 7, 2020
bsamz-ps
suggested changes
Oct 7, 2020
Contributor
bsamz-ps
left a comment
bsamz-ps
left a comment
There was a problem hiding this comment.
Left a small comment about a typo, but seems fine otherwise :)
tlewis-ps
requested review from
mabdelhafez,
msholes-ps,
tsteele-purestorage-com and
vashok-pstg
vashok-pstg
requested changes
Oct 8, 2020
Collaborator
vashok-pstg
left a comment
vashok-pstg
left a comment
There was a problem hiding this comment.
Left some comments on the lifecycle changes regarding optional vs. required fields.
tsteele-purestorage-com
approved these changes
Oct 8, 2020
msholes-ps
reviewed
Oct 9, 2020
mabdelhafez
approved these changes
Oct 9, 2020
msholes-ps
reviewed
Oct 9, 2020
msholes-ps
reviewed
Oct 9, 2020
msholes-ps
reviewed
Oct 9, 2020
msholes-ps
reviewed
Oct 9, 2020
msholes-ps
reviewed
Oct 9, 2020
Collaborator
Author
|
All of the requested feedback has been addressed in the latest fixup commit. Several (a couple hundred) additional files were brought in due to fixes that I made to some common property and parameter descriptions (e.g. name, token, start, etc). These don't contain any functional changes. Just docstring and documentation updates. |
vashok-pstg
approved these changes
Oct 12, 2020
Collaborator
vashok-pstg
left a comment
vashok-pstg
left a comment
There was a problem hiding this comment.
Thanks for fixing the lifecycle required fields Terry!
msholes-ps
approved these changes
Oct 12, 2020
bsamz-ps
approved these changes
Oct 12, 2020
… SDK. In addition to the fixes and new features that are mentioned in README.md, this commit also contains documentation fixes which remove several invalid references and links (such as those to 'str.md'). We've also begun using a slightly updated template for generating the Python for models. These changes have, somewhat unfortunately, contributed to another rather large commit which touches past versions of the SDK, but should not have any functional effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the fixes and new features that are mentioned in README.md, this
commit also contains documentation fixes which remove several invalid references
and links (such as those to 'str.md'). We've also begun using a slightly updated
template for generating the Python for models. These changes have, somewhat
unfortunately, contributed to another rather large commit which touches past
versions of the SDK, but should not have any functional effect.