Skip to content

Feat/claude autogroup#899

Open
Guenael wants to merge 3 commits intopurpleidea:masterfrom
Guenael:feat/claude-autogroup
Open

Feat/claude autogroup#899
Guenael wants to merge 3 commits intopurpleidea:masterfrom
Guenael:feat/claude-autogroup

Conversation

@Guenael
Copy link
Contributor

@Guenael Guenael commented Mar 15, 2026

Tips:

  • please read the style guide before submitting your patch:
    docs/style-guide.md

  • commit message titles must be in the form:

topic: Capitalized message with no trailing period

or:

topic, topic2: Capitalized message with no trailing period

  • golang code must be formatted according to the standard, please run:
make gofmt		# formats the entire project correctly

or format a single golang file correctly:

gofmt -w yourcode.go
  • please rebase your patch against current git master:
git checkout master
git pull origin master
git checkout your-feature
git rebase master
git push your-remote your-feature
hub pull-request	# or submit with the github web ui
  • after a patch review, please ping @purpleidea so we know to re-review:
# make changes based on reviews...
git add -p		# add new changes
git commit --amend	# combine with existing commit
git push your-remote your-feature -f
# now ping @purpleidea in the github PR since it doesn't notify us automatically

Thanks for contributing to mgmt and welcome to the team!

purpleidea and others added 3 commits March 15, 2026 13:39
Add ReachabilityUnsafe() to pgraph which skips per-call TopologicalSort
DAG validation, for use in trusted contexts where the caller already
knows the graph is a DAG. In VertexMerge, switch to ReachabilityUnsafe
and remove the per-merge TopologicalSort check. A safety-net DAG check
is added after the AutoGroup loop exits instead.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Add NonReachabilityFastGrouper alongside the existing
NonReachabilityGrouper. The fast grouper uses kind-family partitioning
so only same-family vertex pairs are compared, and a precomputed
transitive closure cache for O(1) reachability checks instead of
recursive DFS on every pair. Switch callers to use the fast grouper.

Add tests for kindFamily, reachCache, and benchmarks for autogroup
scaling with 10, 100, 1000, and 10000 vertices.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@purpleidea
Copy link
Owner

Cool. FYI this passes, it just needs clean rebasing outside of baddev to pass. I'll do that and then review. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants