Open
Conversation
Add ReachabilityUnsafe() to pgraph which skips per-call TopologicalSort DAG validation, for use in trusted contexts where the caller already knows the graph is a DAG. In VertexMerge, switch to ReachabilityUnsafe and remove the per-merge TopologicalSort check. A safety-net DAG check is added after the AutoGroup loop exits instead. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Add NonReachabilityFastGrouper alongside the existing NonReachabilityGrouper. The fast grouper uses kind-family partitioning so only same-family vertex pairs are compared, and a precomputed transitive closure cache for O(1) reachability checks instead of recursive DFS on every pair. Switch callers to use the fast grouper. Add tests for kindFamily, reachCache, and benchmarks for autogroup scaling with 10, 100, 1000, and 10000 vertices. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Cool. FYI this passes, it just needs clean rebasing outside of baddev to pass. I'll do that and then review. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips:
please read the style guide before submitting your patch:
docs/style-guide.md
commit message titles must be in the form:
topic: Capitalized message with no trailing periodor:
topic, topic2: Capitalized message with no trailing periodor format a single golang file correctly:
Thanks for contributing to mgmt and welcome to the team!