Skip to content

fix: use all persist format items in array #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2022
Merged

fix: use all persist format items in array #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions packages/cli/src/lib/commands/init/options/format.setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,17 @@ import { getEnvPreset } from '../../../pre-set';
export async function setupFormat(
config: RcJson
): Promise<RcJson> {
let format: ReportFormat[] = [];
let format: ReportFormat[] = Array.isArray(config?.persist?.format) ? config.persist.format : [];


if (interactive()) {
let initialFormat: ReportFormat | undefined =
// take the provided formats from cli params or the rc file if given and convert it to a string (yes we cant use multiple initial values :( )
Array.isArray(config?.persist?.format) ? config.persist.format[0] :
typeof config.persist.format === 'string' ? config.persist.format :
// if not use default format from the preset as a suggestion in the prompt choice
undefined;

const { f }: { f: ReportFormat[] } = initialFormat !== undefined ? {f: [initialFormat]}: await prompt<{ f: ReportFormat[] }>([
const { f }: { f: ReportFormat[] } = format.length ? {f: format}: await prompt<{ f: ReportFormat[] }>([
{
type: 'multiselect',
name: 'f',
message: PROMPT_PERSIST_FORMAT,
choices: REPORT_FORMAT_OPTIONS,
initial: initialFormat ? REPORT_FORMAT_VALUES.indexOf(initialFormat) : REPORT_FORMAT_VALUES.indexOf((getEnvPreset() as any).format[0]),
initial: REPORT_FORMAT_VALUES.indexOf((getEnvPreset() as any).format[0]),
// @NOTICE typing is broken here
result(value: string) {
const values = value as any as string[];
Expand Down