A133 transcoding issue due to decoder's block size#3
Merged
viralauraframes merged 4 commits intomainfrom Apr 1, 2025
Merged
Conversation
…erwise transcoding fails on a133
Collaborator
Author
|
This has been pushed to a CX frame that was exhibiting this behavior and seems to have resolved it for them. |
jtomson
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On A133 there are some video resolutions that would not transcode.
Debugging has revealed the following:
Couldn't figure out how to change the encoder format to use the new resolution.
Also couldn't figure out stopping + releasing and restarting the encoder as that makes the decoder and out GL surface for color correction out of sync with the new encoder.
Ultimately,
We know that the decoder is going to change the format midway so we can pre calculate what the decoder's format change is going to be by running an experiment with few different resolution videos.
This reveals that the macro block size that decoder ends up using is 32 and the height and width of the video needs to be a multiple of 32.
This PR makes sure the height and width of the output video is taken as the next multiple of 32.