-
Notifications
You must be signed in to change notification settings - Fork 72
add Pusher Channels mention where absent #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WillSewell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, and I think the channel_client variable makes things clearer (we should do this elsewhere really).
Like with pusher-http-ruby, I suggest also updating the description in package.json.
In addition to that, I think the following should be updated:
- "In order to use this library, you need to have an account on http://pusher.com" -> "In order to use this library, you need to have an account on https://pusher.com/channels"
- "Asynchronous methods on the Pusher Channels class" -> "Asynchronous methods on the
Pusherclass" - "To authorise your users to access private channels on Pusher" -> "To authorise your users to access private channels on Pusher Channels"
- "x-pusher-key - application key, sent by Pusher" -> "x-pusher-key - application key, sent by Channels"
- "x-pusher-signature - WebHook signature, generated by Pusher" -> "x-pusher-signature - WebHook signature, generated by Channels"
- "content-type - must be set to application/json, what Pusher does" -> "content-type - must be set to application/json, what Channels does"
- "Returns the Date object for the time when the WebHook was sent from Pusher" -> "Returns the Date object for the time when the WebHook was sent from Channels"
|
@WillSewell done. Not entirely sure, but I think we might need to update the docs here as well: https://www.npmjs.com/package/pusher. What do you think? |
I think these will be picked up automatically from the master of Github. |
package.json
Outdated
| "description": "Node.js client to interact with the Pusher REST API", | ||
| "version": "2.2.0", | ||
| "description": "Node.js client to interact with the Pusher Channels REST API", | ||
| "version": "2.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure you actually need to make a release for these changes to be picked up on https://www.npmjs.com/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm. I'll try to merge the PR without changing the version and see how it goes.
No description provided.