fix mocha dep #109
Merged
fix mocha dep #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annzenkina
force-pushed
the
fix-mocha
branch
from
0aa8e4b to
e119b63
Compare
annzenkina
force-pushed
the
fix-mocha
branch
from
e119b63 to
909d695
Compare
elverkilde
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The master tests has been failing in Travis since we don't specify the exact versions in Travis config but just
-12which means it installs the latest stable one. Therefore the latest version of node didn't run properly with the old version ofmochawe were using. So I had to update it and the tests dependency -nocklibrary.In order to make the latest versions of node work with the latest versions
mochaandnockI removed the support of 4, 5, 6, 7 versions of node and 9, 11 since they are EOL anyway.travisconfig