Support fetching channel info on trigger #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for a new experimental feature of the Channels API: Specifically the ability to specify an `info` parameter in a trigger body, or with an event in a batch trigger body. The server will respond with attributes in the same format as the `/channels` endpoint. The `info` param is specified in a "params" object, which is passed in as the fourth parameter to the `trigger` method. The `socket_id` parameter is specified in the same way. Note: this introduces a breaking change for users that were passing in a `socket_id`. It is not a breaking change for `triggerBatch`. `triggerBatch` has also been updated to support `socket_id` being included as part of event objects.
WillSewell
force-pushed
the
publish-info
branch
from
10c8d78 to
688c363
Compare
WillSewell
force-pushed
the
publish-info
branch
from
c540b6d to
1a2c418
Compare
WillSewell
force-pushed
the
publish-info
branch
from
16e66e0 to
9f1fbd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a new experimental feature of the Channels API:
Specifically the ability to specify an
infoparameter in atrigger body, or with an event in a batch trigger body. The server
will respond with attributes in the same format as the
/channelsendpoint.
The
infoparam is specified in a "params" object, which ispassed in as the fourth parameter to the
triggermethod. Thesocket_idparameter is specified in the same way.Note: this introduces a breaking change for users that were
passing in a
socket_id.It is not a breaking change for
triggerBatch.triggerBatchhas also been updated to supportsocket_idbeingincluded as part of event objects.
Resolves #134.