RFC: Reduce dependency on Pusher object by move method off prototype #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillSewell
force-pushed
the
end-to-end-encryption
branch
from
2a6fc53 to
459e378
Compare
Makes channelSharedSecret and isEncryptedChannel plain functions in util.js. This means the Pusher object does not need to be passed to encrypt() and getSocketSignature().
WillSewell
force-pushed
the
reduce-dependency-on-pusher-object
branch
from
fb825db to
43dd857
Compare
Contributor
Author
|
Not worth it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't like how the Pusher object was being passed down so deep in the call stack, when the functions that were being used didn't really depend on anything in the Pusher object. This PR makes channelSharedSecret and isEncryptedChannel plain functions in util.js. This means the Pusher object does not need to be passed to encrypt() and getSocketSignature().
It's a pretty minor change and I don't feel too strongly, so feel free to discount.