Forward channel data on private channels #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the auth endpoint returns channel_data, then this should be forwarded to the auth endpoint even if it is not used by private channels currently. This is useful because it allows the same auth endpoint to be used for private and presence channels. It also avoids confusing auth signature errors that occur when the channel_data is not sent (but the auth signature was computed from it). Fixes #144 #144 #144. In order to support the getMe() method on PresenceChannel, we need to store the channel_data in the PrivateChannelImpl class. This is decoded in the PresenceChannelImpl class since presence channels require the channel_data is JSON. It is decoded in toSubscribeMessage() rather than getMe() to preserve the original semantics (e.g. exceptions cannot be thrown from getMe().
TomKemp
reviewed
Sep 2, 2019
src/main/java/com/pusher/client/channel/impl/PresenceChannelImpl.java
Outdated
Show resolved
Hide resolved
Changed storeMyUserId to extractUserIdFromChannelData and moved the side effect of storing the id into toSubscribeMessage.
TomKemp
reviewed
Sep 4, 2019
Contributor
TomKemp
left a comment
TomKemp
left a comment
There was a problem hiding this comment.
I changes look good. I have just left some comments about redundant code.
src/main/java/com/pusher/client/channel/impl/PresenceChannelImpl.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tom Kemp <TomKemp@users.noreply.github.com>
TomKemp
approved these changes
Sep 6, 2019
kn100
reviewed
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the auth endpoint returns channel_data, then this should be
forwarded to the auth endpoint even if it is not used by private
channels currently.
This is useful because it allows the same auth endpoint to be
used for private and presence channels.
It also avoids confusing auth signature errors that occur when the
channel_data is not sent (but the auth signature was computed from
it).
Fixes #144.
In order to support the getMe() method on PresenceChannel, we need
to store the channel_data in the PrivateChannelImpl class. This
is decoded in the PresenceChannelImpl class since presence channels
require the channel_data is JSON. It is decoded in toSubscribeMessage()
rather than getMe() to preserve the original semantics (e.g.
exceptions cannot be thrown from getMe().
CC @pusher/mobile