Covcov #224
Merged
Covcov #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkkid
reviewed
Oct 25, 2017
| try: | ||
| self.sendCommand('timeline/subscribe', port=server_url[1].strip('/'), protocol='http') | ||
| except: | ||
| except: # noqa: E722 |
Collaborator
There was a problem hiding this comment.
if you say except Exception: I believe pyflakes wont yell at you.
Collaborator
Author
|
Btw, is the plexapi username password and token in the test computers env? I would like to swap to using env as the current solution uses the config. And i got my own server in the config.. It make local testing painfull. |
Maybe this shoud be a integration test too.
Hellowlol
commented
Oct 29, 2017
| # we need to reload this as there is a bug in part.delete | ||
| # See https://github.com/pkkid/python-plexapi/issues/201 | ||
| m = movie.reload() | ||
| for part in m.iterParts(): |
Collaborator
Author
There was a problem hiding this comment.
We should iterate over media
Collaborator
Author
|
I'll go ahead and merge this. It's gonna be a while until I have time to complete the rest |
Collaborator
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.