Add Favorite options for Photos

[truenite]

No description provided.

[andrey-yantsen]

Maybe it's better to add a method rate instead of favorite/unfavorite?

[truenite]

Plex UI clients dont show a rate option for pictures, only a hearth to fav them.

[truenite]

Andrey, your plex API has been of great help to me and since I added this, I wanted to contribute. I dedicated 3+hrs on figuring out how to favorite pictures and I wanted to give back to the community. I've tested my code, that's how plex deals with photos and I won't spend any more time on it, it's cool if you want to merge it, I don't have time to convince you, if you don't want to test my changes or you just don't like it, just reject the MR.

…

On Sun, Feb 17, 2019 at 12:56 AM Andrey Yantsen ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In plexapi/photo.py <#342 (comment)>: > @@ -158,6 +172,7 @@ def sync(self, resolution, client=None, clientId=None, limit=None, title=None): sync_item.contentType = self.listType sync_item.metadataType = self.METADATA_TYPE sync_item.machineIdentifier = self._server.machineIdentifier + sync_item.userRating = self.userRating SyncItem object <https://github.com/pkkid/python-plexapi/blob/master/plexapi/sync.py> doesn't knows anything about userRating field, so the field wouldn't be processed in any way there. I'm not really getting it, why have you added it here? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#342 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGVmNanynVcSw5KJlGtUDZ2pJ33jmqhyks5vORlOgaJpZM4a-s64> .

-- Diego Garcia

[andrey-yantsen]

Diego, I appreciate your attempt, and I can only thank you for your time. I've very sorry if you've felt bullied or something like this, it was never in my intentions.

First of all — I'm not anyhow affiliated to the project, I can't accept nor decline any PR, I'm a member of the community, quite the same as you are.

I'm not saying that your code isn't working, and I see that it is working, — as for now I have only one question for you, and the reason for you is simple: I don't understand why you have added just that exact one line of code and how it is supposed to help in favoriting photos.

[andrey-yantsen]

Let me repeat my question: why are you assigning userRating to sync_item here? The SyncItem class knows nothing about this field and therefore it wouldn't be processed anyway. Have you misplaced the assignment and there is a place really waiting for it?

Maybe you could be polite yourself and answer the simple and not rude in any way question without throwing a tantrum? You're in the Internet, man, there are a lot of different cultures (in some of them being straightforward is the proper way of doing things, not the rude one) and not everybody here would like to offend you. Not marking conversation as resolved when it isn't seems for me like a good idea as well.

[Hellowlol]

I agree with @andrey-yantsen a rate option would be better. And while we are at it we should be able to rate movies and episodes to. If you can change the pr to do this I can merge it not, no problem I’ll come back to this later. Thanks for figuring out how to send the rate request 👍

[JonnyWong16]

Photo rating added in #764 through the mixin.