Skip to content

Conversation

JonnyWong16
Copy link
Collaborator

Description

Adds RatingMixin to all objects which can have user star ratings.

Breaking change:

  • Keyword parameter changed from rate(rate) to rate(rating).

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 force-pushed the feature/rating_mixin branch from bb56d6d to e965ebb Compare June 6, 2021 19:54
* Checking if parent is truthy calls the __len__ method which does not work for some Plex objects until after it is initialized with _loadData.
@JonnyWong16 JonnyWong16 merged commit f90698f into pushingkarmaorg:master Jun 6, 2021
@JonnyWong16 JonnyWong16 deleted the feature/rating_mixin branch June 7, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant