Make it easier to set a container size using search #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use totalSize so we dont do any more http requests then needed.
fix comment.
Collaborator
Author
|
@Montellese Does solve your issue with search? |
Montellese
reviewed
Apr 27, 2020
Contributor
Montellese
left a comment
Montellese
left a comment
There was a problem hiding this comment.
The feature set looks good but I proposed some improvements for the handling of container_size and maxresults in LibrarySection.search().
Montellese
reviewed
Apr 27, 2020
Collaborator
Author
|
I think this should be good to go. @Montellese ? |
Montellese
reviewed
Apr 28, 2020
| raise NotFound('Unable to find elem: cls=%s, attrs=%s' % (clsname, kwargs)) | ||
|
|
||
| def fetchItems(self, ekey, cls=None, **kwargs): | ||
| def fetchItems(self, ekey, cls=None, container_start=None, container_size=None, **kwargs): |
Contributor
There was a problem hiding this comment.
How is it possible now to pass container_start and container_size through e.g. LibrarySection.all()? Before it was possible through **kwargs but now it would have to be passed through explicitly which is currently not the case.
Collaborator
Author
There was a problem hiding this comment.
Kwargs can replace keyword arguments. We still test for this.
Montellese
reviewed
Apr 28, 2020
Montellese
reviewed
Apr 28, 2020
Add some test that verify that we cant get in a enless loop and handle container_start corrently.
Closed
Collaborator
Author
|
@Montellese Wanna take a look before i hit merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we still 1 more http call then we need as we just asks for any data until the subresult is empty.If we override fetch item we could use totalSize to check if we have all possible items or not.