Allow overwriting attributes with None when manually reloading #765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current reload behaviour prevents overwriting attributes with
None
. This change allows overwriting attributes withNone
when calling a manualreload()
, but still prevents overwriting when we do the automatic internal reload when accessing a missing attribute.Other changes:
_DONT_RELOAD_FOR_KEYS
and_DONT_OVERWRITE_SESSION_KEYS
to private variables.USER_DONT_RELOAD_FOR_KEYS
public variable for user configurable keys (Closes Accessing optional attributes results in an unnecessary reload #713).TODO: Tests can be updated after rebasing on #763 and #764 which ran into this reloading issue.Fix smart playlists and add support for smart collections #763 - Erasing a collection'scontentRating
resets it back toNone
.Add rating mixin #764 - Resetting an itemsuserRating
resets it back toNone
.Fixes #770
Type of change
Please delete options that are not relevant.
Checklist: